Skip to content

Review containers - #176

Merged
s-sajid-ali merged 4 commits into
mainfrom
review_containers
Sep 29, 2025
Merged

Review containers#176
s-sajid-ali merged 4 commits into
mainfrom
review_containers

Conversation

@RobJY

@RobJY RobJY commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

Just made a few minor changes.

Please let me know if you see anything I've missed or have other suggetions. Thanks!

@RobJY RobJY self-assigned this Sep 11, 2025
@github-actions

github-actions Bot commented Sep 11, 2025

Copy link
Copy Markdown
Contributor
PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-29 17:28 UTC

@s-sajid-ali

Copy link
Copy Markdown
Member

Since the underlying engine on Torch is Apptainer, should we change the naming and let users know that Singularity is an alias that maps to Apptainer now?

@RobJY

RobJY commented Sep 12, 2025

Copy link
Copy Markdown
Contributor Author

Good idea @s-sajid-ali ! I've added a little text explaining that in the intro section What is Singularity. Then when we make the transition to Torch we can just change all references from Singularity to Apptainer and it won't be so jarring for the users.

I just came up with that blurb quickly, so please feel free to suggest changes or make improvements.

@s-sajid-ali
s-sajid-ali merged commit bc780a2 into main Sep 29, 2025
5 checks passed
@s-sajid-ali
s-sajid-ali deleted the review_containers branch September 29, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants